Include order fix #890
Merged
Include order fix #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
May 8, 2017
reuk
force-pushed
the
include-order-fix
branch
2 times, most recently
from
1941d94 to
242d224
Compare
|
Needs a rebase, but otherwise ready to go |
reuk
force-pushed
the
include-order-fix
branch
2 times, most recently
from
80adcd4 to
db1168a
Compare
|
@kroening, looks ready to go. |
|
Apologies, another rebase is needed. |
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header files should include everything that they need in order to compile cleanly. The simplest way to ensure that this is the case is to have each source file include its corresponding header file first, before declaring anything else.
This patch moves includes in source files so that the corresponding header file is always included first. In some cases, this broke the build because the header files weren't standalone. In these cases, the header files have been updated to properly reflect their dependencies.