Assignment typet strong typing and UB fix #864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Is this genuinely a test-gen-support problem only? |
|
Possibly not - closing this in favour of #872. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important part of this patch is the added initialisers in symex_target_equation.h, which fix this warning:
This error was observed in diffblue/platform#520, when cbmc was built using clang's undefined behaviour sanitizer.
Although only the addition on line 209 is strictly required, I've also added initializers for the other primitive data members, because objects should always be in a known state which maintains their invariants once the constructor has finished.
Finally, I changed
assignment_typetinto anenum classto improve its type-safety and avoid undesired conversions.