C/C++ front-end: accept all floating-point extensions that GCC and Clang support #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
kroening
reviewed
Jan 25, 2024
kroening
reviewed
Jan 25, 2024
kroening
reviewed
Jan 25, 2024
| @@ -217,10 +217,13 @@ hexfloat1 "0"[xX]{hexdigit}*"."{hexdigit}+[pP][+-]?{integer} | |||
| hexfloat2 "0"[xX]{hexdigit}*"."[pP][+-]?{integer} | |||
| hexfloat3 "0"[xX]{hexdigit}*[pP][+-]?{integer} | |||
| float_suffix [fFlLiIjJ]* | |||
| gcc_ext_float_suffix [wWqQ]|[dD][fFdDlL]?|"f16"|"f32"|"f64"|"f128"|"f32x"|"f64x"|"f128x" | |||
| clang_ext_float_suffix [qQ]|"f16"|"F16" | |||
There was a problem hiding this comment.
I believe these are standardised in the C++ standards; e.g., bf16 is C++23. They are not clang extensions.
There was a problem hiding this comment.
GCC and Clang support these at varying versions, and while the standard appears to specify them I wasn't able to make them work when using -std=c++23 (Clang) or /std:c++latest (MSVC).
tautschnig
force-pushed
the
bugfixes/float-extensions
branch
from
36f9d99 to
39da677
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8169 +/- ##
========================================
Coverage 79.68% 79.69%
========================================
Files 1681 1680 -1
Lines 195297 195294 -3
========================================
+ Hits 155625 155630 +5
+ Misses 39672 39664 -8 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
bugfixes/float-extensions
branch
from
39da677 to
f27ca35
Compare
tautschnig
force-pushed
the
bugfixes/float-extensions
branch
from
f27ca35 to
e1f6f9a
Compare
tautschnig
force-pushed
the
bugfixes/float-extensions
branch
from
e1f6f9a to
5867ffc
Compare
tautschnig
force-pushed
the
bugfixes/float-extensions
branch
2 times, most recently
from
4735bf5 to
b7a7e38
Compare
…ang support Testing with Compiler Explorer showed that Clang supports a subset of GCC's extensions, and GCC also supports some more extensions than what we previously covered.
tautschnig
force-pushed
the
bugfixes/float-extensions
branch
from
b7a7e38 to
bf1159f
Compare
peterschrammel
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with Compiler Explorer showed that Clang supports a subset of GCC's extensions, and GCC also supports some more extensions that what we previously covered.