fixup! Simplify byte_extract(byte_update(...)) without overlap #7411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bits/bytes confusing, resulting in missed optimisations of byte_extract(byte_update(...)) nestings when the byte_extract was at an offset higher than the update. Found while debugging model-checking/kani#1958.
tautschnig
added
bugfix
Kani
Codecov ReportBase: 78.38% // Head: 78.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7411 +/- ##
===========================================
- Coverage 78.38% 78.36% -0.02%
===========================================
Files 1647 1647
Lines 190343 189969 -374
===========================================
- Hits 149196 148866 -330
+ Misses 41147 41103 -44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 5, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
4 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 5, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
peterschrammel
approved these changes
Dec 5, 2022
#7413 will introduce a compile-time check for this one. |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 6, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 6, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 12, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 14, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 14, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Dec 15, 2022
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 12, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 12, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 12, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Feb 23, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 15, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 15, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jun 1, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 19, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Nov 17, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Nov 20, 2023
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 22, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 22, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 23, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Apr 23, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 8, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 8, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jun 20, 2024
Use mp_integers with a unit to clarify when an mp_integer holds a number of bits or a number of bytes. This makes sure that type-inconsistent comparisons as fixed in diffblue#7411 result in compile-time errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bits/bytes confusing, resulting in missed optimisations of byte_extract(byte_update(...)) nestings when the byte_extract was at an offset higher than the update. Found while debugging model-checking/kani#1958.