Correct pretty-printing of code_returnt #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Mar 20, 2017
There was a problem hiding this comment.
Thank you very much for fixing this - this is my bad as it is caused by e527f64.
|
Note that there is code_returnt::has_return_value()! |
smowton
force-pushed
the
pretty_print_return
branch
from
d47d0b5 to
e843b72
Compare
|
So it does. Amended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I'd made a mistake when I got
return irep("nil")in the symbol table output-- turns out the C pretty-printer just never got updated whencode_returntstarted using a nil irep to represent return-without-value. This cleans it up.