Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jbmc/lib/java-models-library to #11 (enable-monitor-exceptions) #3423

Merged

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Nov 14, 2018

Enables Monitor exceptions in order to allow us to detect errors related to synchronization on null references,
for example.

Includes a pointer bump to diffblue/java-models-library#11

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel peterschrammel force-pushed the enable-monitor-exceptions branch 2 times, most recently from e1b39c6 to 50f62ac Compare November 17, 2018 00:20
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 50f62ac).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91735046

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: b0976a9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91746971

Allows to detect errors related to synchronization on null references
on Monitor enter.

Partially fixes issue 1236.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 71490ae).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91747938

@peterschrammel peterschrammel merged commit d15c08a into diffblue:develop Nov 17, 2018
@peterschrammel peterschrammel deleted the enable-monitor-exceptions branch November 17, 2018 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants