Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefiles: Add missing dependency tracking for smt2_solver #2900

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

tautschnig
Copy link
Collaborator

No description provided.

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not correctly picked up by common?

@tautschnig
Copy link
Collaborator Author

Why is this not correctly picked up by common?

Because common will only use those files listed in $(OBJ), which can't be used, because that file has a main function. #1879 - you have been warned.

@tautschnig tautschnig merged commit 0532e91 into diffblue:develop Sep 5, 2018
@tautschnig tautschnig deleted the smt2_solver-deps branch September 5, 2018 14:58
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 1f860d2).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants