Reduce redundancy between jbmc-string and strings-smoke-tests #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests are the same or test the same functionality.
|
@tautschnig, this conflicts with #2118. Shall we postpone this cleanup after #2118 has been merged? I'd suggest to close this PR in that case. |
|
This PR probably just doesn't make sense in this repository anymore? My suggestion is that whoever takes ownership of the Java repository should migrate this issue and then just close it here. |
|
I've cherry-picked the relevant changes into #1768. |
|
Thank you @peterschrammel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests are the same or test the same functionality.
The following remain to be cleaned up. @allredj @romainbrenguier could you please contribute such cleanup?