Avoid spurious signed/unsigned comparison warnings #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@tautschnig, what do negative values of depth_limit, context_bound, etc mean? Could they be made unsigned?
|
Negative values mean "limit not set"; as briefly discussed on #151 a bound of "0" actually makes sense, and thus can't be used to mark limit-not-set. |
|
What's the difference between 'limit not set' and |
Follow-up to 260e03d: instead of using negative numbers to represent "limit not set", use the maximum value as default.
tautschnig
force-pushed
the
sign-compare-fix
branch
from
b4b435e to
a3578c0
Compare
|
@peterschrammel A very valid question ... - I've changed the implementation to follow your suggestion instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 260e03d: all comparisons are guarded by checks that the
signed integer is >= 0, thus casts to unsigned are safe.