C library modelling: fgets, getopt, vasprintf #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
c-library-ext
branch
from
ea43350 to
2f40a1c
Compare
src/ansi-c/library/getopt.c
Outdated
| const struct option *longopts, int *longindex) | ||
| { | ||
| (void)*longopts; | ||
| (void)longindex; |
There was a problem hiding this comment.
Maybe comment on the purpose of these...
fgets may (and certainly does when successful) change the contents of the buffer passed in. Building a regression test showed further deficiences in the stdio library model: 1) MacOS uses _fdopen; 2) fclose uses free from stdlib.h.
Licensing: I had contributed these myself to the SV-COMP benchmarks.
tautschnig
force-pushed
the
c-library-ext
branch
from
2f40a1c to
f691135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this includes minor bug fixes I'd rather consider these enhancements - not adding a "bugfix" label.