Enable additional warnings with GCC/Clang to match Visual Studio

diffblue · Feb 7, 2025 · 0ca98d2 · 0ca98d2
1 parent 85155f1
commit 0ca98d2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -78,6 +78,7 @@ if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
     #   Enable lots of warnings
     set(CMAKE_CXX_FLAGS
         "${CMAKE_CXX_FLAGS} -Wall -Wpedantic -Werror -Wswitch-enum \
+         -Wextra -Wconversion \
          -Wno-deprecated-declarations -Wno-maybe-uninitialized")
 elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR
        "${CMAKE_CXX_COMPILER_ID}" STREQUAL "AppleClang")
@@ -86,7 +87,9 @@ elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR
     set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
     #   Enable lots of warnings
     set(CMAKE_CXX_FLAGS
-        "${CMAKE_CXX_FLAGS} -Wall -Wpedantic -Werror -Wswitch-enum -Wno-deprecated-declarations")
+        "${CMAKE_CXX_FLAGS} -Wall -Wpedantic -Werror -Wswitch-enum \
+         -Wextra -Wconversion \
+         -Wno-deprecated-declarations")
 elseif("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
     # This would be the place to enable warnings for Windows builds, although
     # config.inc doesn't seem to do that currently

diff --git a/src/config.inc b/src/config.inc
@@ -52,7 +52,7 @@ ifeq ($(BUILD_ENV),MSVC)
   CXXFLAGS += /wd4619
 else
   CXXFLAGS += -Wall -pedantic -Werror -Wswitch-enum
-  CXXFLAGS += -Wno-deprecated-declarations
+  CXXFLAGS += -Wno-deprecated-declarations -Wextra -Wconversion
   # GCC only, silence clang warning
   CXXFLAGS += -Wno-maybe-uninitialized -Wno-unknown-warning-option
 endif