解决issue #13 的bug #14
Merged
解决issue #13 的bug #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
更新了一下 文档链接, 之前的文档只需要将 https的 s 删除 即可; 感谢提交PR
|
我有个疑问， 我在本项目中 使用的是 Router 4 版本 ， 而不是 传统的Router 。 所以 我不希望 让使用者去看 Router 的文档， 而是希望 能跟我保持同步， 查看 http://reacttraining.cn/的文档 或者 https://github.com/ReactTraining/react-router |
|
@didilinkin 我不太明白你的意思。 |
|
@pei-han 是这样， Router 4 跟 Router (默认版本) 之间的 API 和 使用方式 是完全不兼容的 两个版本, 所以我希望 尽量能保持统一 使用 Router 4的文档， 而不是看 默认版本的 文档( 我担心出现一些无法理解的 问题 ， 比如 路由守卫钩子什么的， Router4 是其他方式实现的) |
|
断裂式的升级 😂 |
pei-han
commented
Jun 4, 2018
README.md
Outdated
| @@ -20,7 +20,7 @@ | |||
| | [react](https://facebook.github.io/react/) | 视图库 | 15.6.1 | | |||
| | [redux](http://cn.redux.js.org/) | 状态管理 | 3.7.1 | | |||
| | [react-redux](http://cn.redux.js.org/docs/react-redux/index.html) | Redux的 React 绑定库 | 5.0.5 | | |||
| | [react-router](https://reacttraining.cn/) | 路由管理 | 4.1.1 | | |||
| | [react-router](http://react-guide.github.io/react-router-cn/index.html) | 路由管理 | 4.1.1 | | |||
There was a problem hiding this comment.
@didilinkin 你说的是这个地方的修改的文档URL吗？
|
@didilinkin 我猜你的意思，是不是在说，我上一个PR对react-router文档URL的更新，你觉得它不是router4的文档？ |
|
@pei-han 确实，是这个意思。 我大概看了一下 感觉它的内容 跟我们当前的项目版本 不太相符。 你可以也看看 |
Fix 'Router 4' doc link
|
Fix 'Router 4' doc link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13