Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standing still button usage in Town #3290

Closed
licaon-kter opened this issue Oct 26, 2021 · 4 comments · Fixed by #3888
Closed

Standing still button usage in Town #3290

licaon-kter opened this issue Oct 26, 2021 · 4 comments · Fixed by #3888
Assignees
Milestone

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Oct 26, 2021

Important information
0487351 Android 11

Describe
Standing still button (#3281) feels useless in Town

Expected behavior
Two ideas

  • hide it in Town
  • use it to switch from Run In Town to Walk In Town (if possible)
@AJenbo
Copy link
Member

AJenbo commented Oct 27, 2021

use it to switch from Run In Town to Walk In Town (if possible)

That's a good ide, though we should update the graphics to match that.

By the way you may now enable builds in Fdroid if you like.

@licaon-kter
Copy link
Contributor Author

As much as I'd like to have it alongside OpenMW and Freedoom, this might not be eventually possible in the main F-Droid repo.

The license is at fault, "The Unlicense" (as the LICENSE text says) is both OSI and FSF approved, so pretty great freedom wise, and I was pretty excited to have this in F-Droid as I read it, but I didn't notice that the Readme (and explained here diasurgical/devilution#2208) adds a limitation on top, it states "non-commercial only", and adding this limitation makes the whole code non-FOSS licensed.

Why was that limitation added in the first place? Was Blizzard legal involved? Just a precaution? :(

Even if the main F-Droid repo can't have it, we can ask @IzzySoft to pick APKs directly from the Github releases for his F-Droid repo, but was wondering if at least a non-ZeroTier flavour could be added, since that's non-FOSS too.

@AJenbo
Copy link
Member

AJenbo commented Oct 28, 2021

We where asked to keep it non-commercial. The APK produced by the CI is a debug build and not suitable for distribution, ZeroTier can be omitted simply by providing -DDISABLE_ZERO_TIER as a CMake option.

@AJenbo AJenbo added this to the 1.4.0 milestone Oct 28, 2021
@IzzySoft
Copy link

As my name was called: Yes, you can ask me. But my repo has some "inclusion policy" as well, and that usually excludes games, sorry… And no idea where you saw an APK – the closest match to that I can find are *.opk files (no idea what those are) 😉

@AJenbo AJenbo self-assigned this Jan 2, 2022
AJenbo added a commit that referenced this issue Jan 3, 2022
AJenbo added a commit that referenced this issue Jan 3, 2022
kphoenix137 pushed a commit to kphoenix137/devilutionX that referenced this issue Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants