fixing modal visibility issue #7191
Conversation
|
Nice catch! Could you add a test for this? One similar to this test would be great, where you just click on the other link to open the invitation modal. |
There was a problem hiding this comment.
I just had two minor remarks.
Please squash your commits so we only have one commit at the end. Putting different behavior changes in different commits is a great thing but in this case it is just one change and a test for it. As long as you are still working on something you may of course have commits fixing/extending stuff from earlier commits.
| @@ -49,6 +49,15 @@ Feature: Invitations | |||
| Then I should have 1 Devise email delivery | |||
| And I should not see "change your notification settings" in the last sent email | |||
|
|
|||
| Scenario: sends an invitation from a page link | |||
There was a problem hiding this comment.
sends an invitation from the stream
| @@ -49,6 +49,15 @@ Feature: Invitations | |||
| Then I should have 1 Devise email delivery | |||
| And I should not see "change your notification settings" in the last sent email | |||
|
|
|||
| Scenario: sends an invitation from a page link | |||
| When I sign in as "[email protected]" | |||
| And I click on selector "a.invitations-link" | |||
There was a problem hiding this comment.
I'd prefer And I click on "invite" within "#no_contacts". In the sidebar we also have the invitations-link class but in that case it is a div. This could be confusing.
|
Merged as c7a0b05. Thank you! |
|
Thanks and congrats for these first pull requests :D |
As a user viewing my stream, when I click on "You can search or invite more contacts.", the modal backdrop appears but the modal content is invisible. This is because the element containing the modal in the sidebar is hidden until the "invite" section is uncollapsed.
This PR moves the modal to
:after_content.