Hide publisher cancel button on xsmall screens #6435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As said on #6336, it'd be better to reduce it as a cross on a corner than simply remove it :D |
|
Yeah, but waiting for someone to do it, I propose to hide it at the moment ;) |
|
Meh :( |
|
The way I think about it is: I want people to love diaspora*, so to love their experience there. How frustrated would you be if you loose a big message you spent time to enter with your mobile VS how frustrated would you be if you have to reload the page / manually clean the publisher? The first is the worst in my opinion. |
|
True that. |
|
The travis failure looks unrelated. |
Flaburgan
force-pushed
the
publisher-xsmall-cancel
branch
from
964cdc8 to
97a5a5c
Compare
svbergerem
pushed a commit
that referenced
this pull request
Sep 30, 2015
Hide publisher cancel button on xsmall screens
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said on #6336 I think the "Remove all text" feature of the publisher is not that useful compare to the risk of a misclick on that very big button.