Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable project location #148

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Editable project location #148

merged 2 commits into from
Jul 19, 2022

Conversation

weetster
Copy link
Contributor

When using Poetry for building virtual environments, all package entries have a "location" key with a file path in the pip list output. This results in pip-api determining that all packages are editable, which is incorrect. As of pip version 21.3, an editable_project_location key is available, which is a better indicator of whether a package is truly editable. I've added support to pip-api for using this key, which should provide more accurate information for virtual environments, especially ones created with Poetry.

Thanks in advance for your review.

@di di merged commit 3ef90ae into di:master Jul 19, 2022
@di
Copy link
Owner

di commented Jul 19, 2022

Thanks! If you have an interesting use case for pip-api and wouldn't mind adding it here, I'd appreciate it!

@weetster
Copy link
Contributor Author

Thank you for merging my changes and doing a release! I'm not using pip-api directly (only through pip-audit), so I don't have anything to add to use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants