Add support for Filco 91 JIS + Pegasus Hoof #28
Conversation
* Make 5 missing JIS keys addressable via matrix coordiates.
* Enable HID_KEYBOARD_SC_INTERNATIONAL{1-5}
* Assign new keys to their corresponding keys
* Adjust costar87.cfg to look nice with the various layouts
cmack
changed the title
|
this is great. I'm really thrilled someone is able to test JIS. I have no idea how it works so the help is appreciated. I have not yet gone through the changes (on mobile right now) but I think more will be needed to get it working. Going to make a branch with this pull and work it tomorrow |
|
I'm glad to help any way I can. I see now that there might need to be an adjustment to the |
|
Yes, that needs to be updated. Also the NKRO vector isn't long enough to cover these keys, so I will have to attempt to adjust that. Also, we will want to add the new keys to the scancode picker. I'm still on it. |
|
I committed some updates. I don't really have time to check if they will work. Want to give it a shot? |
|
I just tried it out and no joy :( I am trying on a mac which is a new variable. However I was able to assign normal letters to the new keys on a function layer and they worked as expected, so I think this test should be accurate (true negative). I'll take the keyboard home with me tonight and try on my linux machine to be sure. Is there a way to create and send debug logs of what the keyboard is doing? Or is there any other helpful info I can generate and send? |
|
Hey, I forgot to mention. Please try it with NKRO turned off. You can do it in the config menu. That will really help, thanks. |
|
Alright. "6KRO boot-compatible keyboard only" still appears to be no-joy on macos. Will try again with linux tonight |
|
good news! I just plugged it in to my linux box and all new keys are recognized! |
|
I just tried with NKRO... it did not seem to like that; had to reset with ENTER held down |
|
Okay well the important thing is that the 5 new keys work. I can deal with the USB stuff on my own US keyboard. Probably this weekend... busy lately. By the way, when you hold down Enter it resets to the default, which is NKRO. Also, keep in mind that these new builds alter the structure of the USB interface, so you should completely unplug and replug the keyboard after reprogramming the first time. |
|
I'm going through and cleaning up old stuff. I have to admit I don't even remember working this last year. Based on the timing I probably got distracted by the new baby. Should this request be revived? |
|
Well now I'm dealing with a new baby myself. I haven't had time for keyboard programming lately and sometimes it feels like I'm the only westerner working on a JIS layout... I'd hate to see it die but testing the conflict resolution might take a long while to confirm on my end :/ |
Needs Review
This is my first time hacking on this project so I may not be doing this "The Right Way"...
I have a Filco JIS layout Majestouch 2 TKL keyboard. I just put a Pegasus Hoof in today and everything worked almost as expected except for my JIS-unique keys. Here is an image of the keyboard for reference
Goals
My goal with this patch is to
Status
HID_KEYBOARD_SC_INTERNATIONAL1-HID_KEYBOARD_SC_INTERNATIONAL5. I had to uncomment these key code definitions in thescancodes.pyfile. These values are now assignable via the UI but don't seem to send the keycodes to the OS after flashing. (I'm testing this usingxevon linux). Is there something simple I'm missing? Is there a different approach I should follow instead?Other Impact
I made this layout as an alternate to the current
filco87v2. The addition of 5 new keys made it necessary to put more overrides / key hiding in thecostar87.cfgso thatAll keys,iso 88,ansi, andjislayouts look nice.