Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array of ads used for "settings & ads" backup doesn't update, only is set on init #2298

Closed
mneunomne opened this issue Feb 24, 2023 · 3 comments
Assignees
Milestone

Comments

@mneunomne
Copy link
Collaborator

When exporting "settings & ads" the list of collected ads is not updated to the latest state, only to the state of the last start-up of AdNauseam.

Screenshot 2023-02-24 at 23 51 20

For example, if you start-up with no ads, then collect some, then try to export, they won't be included in the "settings & ads" backup download. Also if you try to clear the ads then make the "settings & ads", the deleted ads will still appear in the downloaded .json.

The backup option "only ads" still works fine, also the export from the vault, it is only the case of the "settings & ads" option, since the ad list is coming from different place in the code.

Currently on master, have no idea since when this bug is there, it's a bit tricky to catch if you already have a big ad set, you will never notice that some (the latest) are missing.

@mneunomne
Copy link
Collaborator Author

Everytime a user starts up the browser, or reloads the extension, this object will be set again, it only doesn't update to the "current session".

@mneunomne mneunomne mentioned this issue Feb 24, 2023
mneunomne added a commit to mneunomne/AdNauseam that referenced this issue Feb 24, 2023
@mneunomne
Copy link
Collaborator Author

µb.changeUserSettings('admap', admap);

Fixed it, apparently the userData was not being updated when the storage data was.

dhowe added a commit that referenced this issue Feb 25, 2023
@mneunomne
Copy link
Collaborator Author

Fixed, closing

@mneunomne mneunomne added this to the Version 3.16 milestone Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant