Responsive graph #32
Merged
Responsive graph #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recenters the graph as the size changes
this function stops the graph from being responsive. cost benefit required before pull request. do we prefer the fixed nodes to responsive_graph
3 tasks
This reverts commit 27ea5c4.
ryaanahmed
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Makes the graph re-center when window size changes. Switches to using the inbuild d3 window size event listener instead of using the one defined in the main.js. Removes the need for an update_graph_size function defined external to the graph.
Opening an issue because once a node is clicked it stops being responsive. Other parts of the code fix positions of all nodes when a node is clicked so that needs to be dealt with.