feat: add 2FA type in authentication error message #19894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morten Svanaes <[email protected]>
Signed-off-by: Morten Svanaes <[email protected]>
|
vietnguyen
approved these changes
Feb 10, 2025
jbee
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement a way to differentiate between TOTP 2FA and Email 2FA.
Currently, when you are logging in, and you are required to enter 2FA, the server will respond with
INCORRECT_TWO_FACTOR_CODE. To make it possible for the FE to respond to the user if the user needs to check their email or use an authenticator app, we need to have two different response codes, one for each 2FA type.The new response codes are:
INCORRECT_TWO_FACTOR_CODE_EMAILINCORRECT_TWO_FACTOR_CODE_TOTP