Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove store interfaces in tracker [DHIS2-18883] #19881

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: Remove store interfaces in tracker [DHIS2-18883] #19881

wants to merge 4 commits into from

Conversation

enricocolasante
Copy link
Contributor

@enricocolasante enricocolasante commented Feb 7, 2025 •
edited
Loading

  • Remove RelationshipStore interface and other tracker entities store interfaces.

Next steps

  • Pass field params to RelationshipService in order to only retrieve from the DB what is needed.
  • Check how we should deal with deleted entities in RelationshipService.

@enricocolasante enricocolasante changed the base branch from master to DHIS2-18883 February 9, 2025 19:26
@enricocolasante enricocolasante changed the base branch from DHIS2-18883 to master February 9, 2025 19:26
@enricocolasante enricocolasante force-pushed the DHIS2-18883-remove-interface branch from dd21cf6 to 5c82dc7 Compare February 10, 2025 08:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
D Maintainability Rating on New Code (required ≥ A)
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@enricocolasante enricocolasante marked this pull request as ready for review February 10, 2025 15:25
@enricocolasante enricocolasante requested a review from a team as a code owner February 10, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enricocolasante