feat: add hibernate.show_sql to dhis.conf #19873
Conversation
|
| * Show SQL statements generated by hibernate in the log. Can be 'true', 'false'. (default: false) | ||
| * This will also enable hibernate.format_sql and hibernate.highlight_sql | ||
| */ | ||
| HIBERNATE_SHOW_SQL("hibernate.show_sql", "false", false), |
There was a problem hiding this comment.
How is this different from changing the log4j2 config to enable logging 🤔
There was a problem hiding this comment.
There was a problem hiding this comment.
@teleivo Sometimes changing the log4j config doesn't work for me. Have you ever experienced that ?
There was a problem hiding this comment.
Mhm, I mean our log setup is pretty complex 😅 You need to configure the correct file depending on what/how you execute code. Maybe share your use case and we'll figure it out together. I just wonder if adding another way is not more confusing/complex 🤔 also if you want to see jdbc logs you'll need to go to log4j2.
There was a problem hiding this comment.
My use case is just to know what queries hibernate are generating in test and also production code.
I think using the log4j config is more complicated, and I also have to remember revert the changed before merging.
Using dhis.conf is straight forward, and i just need to change my local file. Maybe it's easier for debugging deployed instance, you don't need to look for the log4j file in the built folder.
I don't think there is a confusion regarding adding two ways to enable hibernate debug. It just helps to make the debugging job easier.
There was a problem hiding this comment.
Using dhis.conf is straight forward, and i just need to change my local file. Maybe it's easier for debugging deployed instance, you don't need to look for the log4j file in the built folder.
I think that is due to a lack of understanding logs 😅 Users can provide their config. They do not need to touch the config we ship by default.
I don't think there is a confusion regarding adding two ways to enable hibernate debug. It just helps to make the debugging job easier.
I disagree but maybe others agree. With this you now have 2 options to enable hibernate logging. If you want to enable jdbc logging you are then left wondering why there is no dhis.conf option for that and have to go to log4j2 anyway.
|
Close this for now. If there would be more requests from others then we could reopen. |
No description provided.