-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ifttt notifications #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
I hadn't used IFTTT before, but in theory it seems like a more versatile and flexible notification solution compared to the Telegram bot. The interface was a bit unintuitive for me, but I was able to follow the instructions all the way through. At the end I created an applet described as:
If Maker Event "hackjohn", then Send a rich notification from the IFTTT app Activity
The part that took me the longest was actually realizing that I had to click "+" sign to begin creating the applet.
I made a few small suggestions, if you want to accept those, then I will merge this PR.
# Set enable_ifttt to True to receive IFTTT notification | ||
enable_ifttt = True | ||
event_name = 'hackjohn' | ||
ifttt_key = 'cJLFuy0CHPBwK0wqndI2g9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ifttt_key = 'cJLFuy0CHPBwK0wqndI2g9' | |
ifttt_key = 'replace-with-ifttt-key' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neuhoffm, do you not think this is a worthwhile change? Is cJL....
a real key or just an example? We will want to do whatever is most clear to let users know that they must replace the value with their key.
hackjohn.py
Outdated
## Notifications using IFTTT | ||
|
||
# Set enable_ifttt to True to receive IFTTT notification | ||
enable_ifttt = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable_ifttt = True | |
enable_ifttt = False |
let's default to false since users will have to populate the ifttt fields first
ifttt_key = 'cJLFuy0CHPBwK0wqndI2g9' | ||
|
||
# Create you own IFTTT (https://ifttt.com/create) | ||
# Select webhooks for this and select receive a web trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Select webhooks for this and select receive a web trigger | |
# Select webhooks for this and select "Receive a web request". |
for referencem, here are some URLs that the process took me to:
https://ifttt.com/create/connect-maker_webhooks?sid=3
https://ifttt.com/create/if-receive-a-web-request?sid=9
https://ifttt.com/create/if-receive-a-web-request-then-send-a-rich-notification-from-the-ifttt-app?sid=14
Co-Authored-By: Daniel Himmelstein <[email protected]>
As we discussed in #1. Sorry for the delay :(