Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small clarifications, links #43

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

dmcc
Copy link
Contributor

@dmcc dmcc commented Apr 26, 2024

I explicitly specified calm parameter in pollutionroseplot to make it a little clearer where that fits in.

dmcc added 2 commits April 26, 2024 15:10
I explicitly specified `calm` parameter in `pollutionroseplot` to make it a little clearer where that fits in.
Semicolons were intentional to prevent the return from the function for the purpose of the notebook.
@dmcc dmcc changed the title Add small clarifications, links, remove spurious semicolons Add small clarifications, links Apr 26, 2024
At some point, would be nice to linkify this, but not critical for now.
@dmcc
Copy link
Contributor Author

dmcc commented Apr 26, 2024

Code blocks were also formatted in Black-style with ruff's formatter.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (450aed8) to head (888934a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   69.01%   69.01%           
=======================================
  Files          11       11           
  Lines         384      384           
=======================================
  Hits          265      265           
  Misses        119      119           
Flag Coverage Δ
unittests 69.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhhagan dhhagan merged commit dd72dbc into dhhagan:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants