-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Cabal 3.0. #183
Upgrade to Cabal 3.0. #183
Conversation
00b5fbb
to
1960998
Compare
Well, that's an interesting error in CI:
|
1960998
to
06b2dca
Compare
My best guess at what's going on: the generic builder is using Looking at the generic builder's code, which features a 'scary sed expression', it's not entirely surprising that it's been broken and will need porting. @Gabriel439 - you know the most about Nix out of the lot of us, I think. Is that plausible? And, if you figure that's the cause, is there a way to get the |
@quasicomputational: Usually for this sort of thing it's easiest to upgrade to a newer version of Nixpkgs (analogous to upgrading to a newer This is the part that is responsible for selecting the revision of Nixpkgs: Lines 4 to 10 in 355ef9d
You can simplify it a little bit by using the updated instructions here: https://nixos.wiki/wiki/How_to_fetch_Nixpkgs_with_an_empty_NIX_PATH ... so that you can use The current tip of When upgrading to a newer revision of Nixpkgs you may need to unpin or update the pinned |
The pinned version is fairly old and there have been some improvements to the generic builder since then, which might help with dhall-lang#183. Also the package set has more current versions, allowing a whole lot of overrides to be culled. I've moved the remaining one override (for `dhall`) into the `overrides/` subdirectory, for neatness and to segregate them from infrastructural `.nix` files.
The pinned version is fairly old and there have been some improvements to the generic builder since then, which might help with #183. Also the package set has more current versions, allowing a whole lot of overrides to be culled. I've moved the remaining one override (for `dhall`) into the `overrides/` subdirectory, for neatness and to segregate them from infrastructural `.nix` files.
06b2dca
to
ccb118e
Compare
Upgrading the pinned nixpkgs seems to do the trick - at least, now I have The next blockage is |
80fd656
to
8159270
Compare
8159270
to
2df068a
Compare
|
2df068a
to
8f7b281
Compare
stack build
is broken and so this probably shouldn't be merged yet.Things I'm not quite sure about:
Should we put in some new convenience functions for depending on only the main library? There's a lot of
[ types.LibraryName.main-library ]
.Should the
Text
inPkgconfigVersionRange
be abstracted into aPkgconfigVersion
, like howVersion
is?Naming bikeshedding welcome.