Replace & remove runUnion #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to rewrite the relevant code in CabalToDhall without using runUnion.
quasicomputational
force-pushed
the
no-runUnion
branch
from
014c576 to
68bcc1c
Compare
|
Oh yeah, this closes #84. I knew I'd talked about this somewhere before. |
ocharles
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runUnionstops GHC helping us out with case exhaustivity checking.In the course of making this PR and getting the benefit of GHC's assistance, I discovered that we weren't handling
AArch64properly, which is an obvious and easily corrected oversight.It's also made two other incomplete matches visible, but they're slightly less obviously corrected. As this PR isn't making things worse, only revealing problems that already existed, I've elected to leave those as they are.