Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't normalize partially saturated {List,Natural}/fold #1742

Merged
merged 5 commits into from
Apr 10, 2020
Merged

Don't normalize partially saturated {List,Natural}/fold #1742

merged 5 commits into from
Apr 10, 2020

Conversation

Gabriella439
Copy link
Collaborator

... to match the regression test added in:

dhall-lang/dhall-lang#950

sjakobi
sjakobi approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I believe we'll have to make a similar change for List/fold though, right?

⊢ List/fold Natural [1]

λ(list : Type) → λ(cons : Natural → list → list) → λ(nil : list) → cons 1 nil

@Gabriella439 Gabriella439 changed the title Don't normalize partially saturated Natural/fold Don't normalize partially saturated {List,Natural}/fold Apr 9, 2020
@Gabriella439
Fix property test failure
89ae084 
The Hydra build failed due to `isNormalized` not being consistent with
`normalize`
@Gabriella439 Gabriella439 merged commit a6c92bb into master Apr 10, 2020
@Gabriella439 Gabriella439 deleted the gabriel/fix_Natural_fold branch April 10, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriella439 @sjakobi