Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhall-to-toml: No proper CLI #2353

Closed
amesgen opened this issue Dec 21, 2021 · 1 comment · Fixed by #2355
Closed

dhall-to-toml: No proper CLI #2353

amesgen opened this issue Dec 21, 2021 · 1 comment · Fixed by #2355
Labels
dhall-toml enhancement

Comments

@amesgen
Copy link
Contributor

amesgen commented Dec 21, 2021

The usual stuff provided by optparse-applicative (--version, --help, input/output as file/stdin/stdout) is missing from dhall-to-toml and toml-to-dhall.

This should be easy to add, but maybe there could even be some shared code for the various dhall-someformat projects?
amesgen added a commit to amesgen/easy-dhall-nix that referenced this issue Dec 21, 2021
@amesgen
Update to 1.40.2, add dhall-csv
12008ca 
I did not add dhall-toml due to dhall-lang/dhall-haskell#2353
amesgen added a commit to amesgen/easy-dhall-nix that referenced this issue Dec 21, 2021
@amesgen
Update to 1.40.2, add dhall-csv
af2ab20 
I did not add dhall-toml yet due to dhall-lang/dhall-haskell#2353
@amesgen amesgen mentioned this issue Dec 21, 2021
Merged
@sjakobi
Copy link
Collaborator

sjakobi commented Dec 21, 2021

Yes, proper CLIs would be very nice to have!

This should be easy to add, but maybe there could even be some shared code for the various dhall-someformat projects?

The various option parsers do have things in common, but they also have a lot of differences. I suspect that it might be easiest to keep them separate. AFAIK this hasn't caused us much maintenance hassle so far.

@amesgen amesgen mentioned this issue Dec 22, 2021
Merged
@toastal toastal mentioned this issue Feb 19, 2022
Closed
@amesgen amesgen mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dhall-toml enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dhall-toml: Add basic optparse-applicative CLI amesgen/dhall-haskell
2 participants
@sjakobi @amesgen