Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #25 #28

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix for #25 #28

merged 2 commits into from
Dec 12, 2024

Conversation

shahronak47
Copy link
Collaborator

Hi @dgkf , this PR fixes #25 where "Add Filter" is not populated for shiny > 1.8.0 .

@dgkf
Copy link
Owner

dgkf commented Nov 22, 2024

Thanks @shahronak47 - this looks like a perfectly fine fix to me!

As an aside, I do very little maintenance on this project and I know you've been engaged with it for a couple years now. Would you be interested in being a formal collaborator so that you can take more ownership over this repo?

@shahronak47
Copy link
Collaborator Author

Thanks @dgkf , we have forked shinyDataFilter package for an internal project and I have been maintaining and building new features in that package. I have some idea about internal workings of this package and would like to gain more understanding in it. So I would definitely like to be a collaborator on this.

@shahronak47
Copy link
Collaborator Author

Hi @dgkf , I have accepted the invite for collaboration on this repo. How do we want to proceed working on this? Do you have some ways of working together on this? Any suggestions?

@dgkf
Copy link
Owner

dgkf commented Dec 12, 2024

Ideally would re-trigger CI now that it's been updated on main, but I'm not seeing how to do it on GitHub (personally, I find GitLab & codeberg much more intuitive for this sort of thing).

In the absence of a clear path forward and not wanting to slow this down by asking you to do a trivial commit just to re-trigger CI, I'm going to YOLO merge this. Not expecting issues with a fairly simple fix, but if anything pops up I'll manage it in a follow-up PR.

@dgkf dgkf merged commit 0a653d4 into dgkf:master Dec 12, 2024
0 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"add Filter" button not populated when using shiny >= 1.8.0
2 participants