chore: update frontend templates #4003
Conversation
ghost
self-requested a review
as a 
src/dfx/assets/project_templates/vanilla_js/src/__frontend_name__/assets/.ic-assets.json5
Outdated
Show resolved
Hide resolved
src/dfx/assets/project_templates/vue/src/__frontend_name__/public/.ic-assets.json5
Outdated
Show resolved
Hide resolved
| // Once you improved the headers for your dapp, set the security policy to "hardened" to disable the warning. | ||
| // Options are: "hardened" | "standard" | "disabled". | ||
| "security_policy": "standard", | ||
|
|
There was a problem hiding this comment.
Right now the remaining changes to these .ic-asset.json files are whitespace-only: changing the indentation, and removing some newlines (newlines that improved readability). Can we make it so this PR doesn't change these files at all?
There was a problem hiding this comment.
the "standard" policy does not work on safari. I've added an identical CSP to each project currently works on Safari, but that should be updated at a later date when dfx can do the handling of CSP between dev / prod modes
There was a problem hiding this comment.
When I create a new project using the SvelteKit frontend and load using a URL like http://127.0.0.1:4943/?canisterId=bd3sg-teaaa-aaaaa-qaaba-cai, I see the expected page:
However, when I type a name and press the button:
When using a URL like http://bd3sg-teaaa-aaaaa-qaaba-cai.localhost:4943/, the CSS does still work, but the name doesn't show up after "Click Me!"
raymondk
force-pushed
the
update-frontend-templates
branch
from
e94ee76 to
76e6da9
Compare
|
Dear @ghost, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
|
Closing this PR to get around the CLA issue for |
Description
This PR updates the frontend templates to a design provided by the design team, updates the default CSP so that hello world projects are operational on Safari locally, and updates dependencies on Sass to remove deprecation warnings.
Resolves: