Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redeem cycles faucet coupon to cycles ledger #3515

Conversation

smallstepman
Copy link
Contributor

@smallstepman smallstepman commented Jan 18, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@smallstepman smallstepman force-pushed the SDK-1308-dfx-calls-cycles-faucet-endpoint-if-no-wallet-exists branch from 26ee3b0 to 56fed42 Compare January 23, 2024 14:17
@smallstepman smallstepman force-pushed the SDK-1308-dfx-calls-cycles-faucet-endpoint-if-no-wallet-exists branch from 56fed42 to 862750a Compare January 23, 2024 14:18
@sa-github-api
Copy link

Dear @smallstepman,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@sesi200
Copy link
Contributor

sesi200 commented Feb 5, 2024

Closing in favor of #3569 because of CLA

@sesi200 sesi200 closed this Feb 5, 2024
@ericswanson-dfinity ericswanson-dfinity deleted the SDK-1308-dfx-calls-cycles-faucet-endpoint-if-no-wallet-exists branch May 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants