feat(frontend-canister): Add simple aliasing rules #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
commented
Oct 26, 2022
ericswanson-dfinity
requested changes
Oct 26, 2022
src/canisters/frontend/ic-certified-assets/src/state_machine.rs
Outdated
Show resolved
Hide resolved
src/canisters/frontend/ic-certified-assets/src/state_machine.rs
Outdated
Show resolved
Hide resolved
src/canisters/frontend/ic-certified-assets/src/state_machine.rs
Outdated
Show resolved
Hide resolved
|
|
||
| // path like /path/to/my/asset should also be valid for /path/to/my/asset.html | ||
| fn redirect(key: &Key) -> Option<Key> { | ||
| if !key.ends_with(".html") { |
There was a problem hiding this comment.
Is it intended that this should convert /path/to/my/asset.gz to /path/to/my/asset.gz.html ?
There was a problem hiding this comment.
Not necessarily 'intended' but I think if someone creates a file /path/asset.gz.html and doesn't have a file /path/asset.gz I don't think it's unreasonable to redirect that
src/canisters/frontend/ic-certified-assets/src/state_machine.rs
Outdated
Show resolved
Hide resolved
src/canisters/frontend/ic-certified-assets/src/state_machine.rs
Outdated
Show resolved
Hide resolved
sesi200
changed the title
<asset> to <asset>.html
sesi200
commented
Nov 9, 2022
| for (asset_name, asset) in state.assets.iter_mut() { | ||
| for enc in asset.encodings.values_mut() { | ||
| enc.certified = false; | ||
| let assets_keys: Vec<_> = state.assets.keys().map(|key| key.clone()).collect(); |
There was a problem hiding this comment.
This clone is not nice, but I can't find a better way to satisfy the borrow checker. Suggestions are very welcome
Co-authored-by: Eric Swanson <[email protected]>
Co-authored-by: Eric Swanson <[email protected]>
ericswanson-dfinity
approved these changes
Nov 14, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The asset canister now by default redirects any request to
<asset>to<asset>.html.This can be disabled by setting the field
"redirect"tofalsein the canister settings in dfx.json.Fixes SDK-789
How Has This Been Tested?
added e2e
Checklist: