Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support the new sns sale payment flow for the ticketing system #156

Merged
merged 12 commits into from
Feb 9, 2023
Merged

feat: support the new sns sale payment flow for the ticketing system #156

merged 12 commits into from
Feb 9, 2023

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Feb 8, 2023 •
edited
Loading

Description

Close SDK-953

Checklist:

  • I have made corresponding changes to the documentation in src/docs.

@lwshang lwshang marked this pull request as ready for review February 8, 2023 14:07
@lwshang lwshang mentioned this pull request Feb 8, 2023
Closed
MarioDfinity
MarioDfinity previously approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@MarioDfinity MarioDfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, only a couple of minor comments. You can merge when ready.

docs/cli-reference/sns/quill-sns-new-sale-ticket.md Outdated Show resolved Hide resolved
docs/cli-reference/sns/quill-sns-new-sale-ticket.md Outdated Show resolved Hide resolved
docs/cli-reference/sns/quill-sns-pay.md Outdated Show resolved Hide resolved
ghost
ghost approved these changes Feb 9, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping since @MarioDfinity already approved

@lwshang lwshang merged commit 6c2b6ee into master Feb 9, 2023
@lwshang lwshang deleted the lwshang/sdk-921 branch February 9, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioDfinity MarioDfinity MarioDfinity left review comments

@DanielThurau DanielThurau Awaiting requested review from DanielThurau

@adamspofford-dfinity adamspofford-dfinity Awaiting requested review from adamspofford-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lwshang @MarioDfinity