feat: Migrate SNS commands #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Several sns-quill PRs by Martin were merged recently. Especially, dfinity/sns-quill#36. Could you apply those changes here? |
lwshang
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges sns-quill with quill. Implements SDK-933. All sns-quill commands can now be found under a
quill snssubcommand.Quill previously only dealt with fixed canisters, but SNSes can be anywhere; to that end, the message JSON format now has a
rolefield, to mark what sort of canister it is supposed to be, so that the program sending the message can render the response without needing the original command. This will get more use with for example future ICRC-1 support. Verified manually that it does not cause any problems with the QR scanner.sns-quillcommands that did not write messages, such assns-quill qr, were not migrated as the functionality already exists inquill. The test outputs were copied verbatim from the sns-quill repo rather than regenerated.