fix wrong EC_PARAMETERS

[lau-bin]

Wrong elliptic curve parameters cause the "generate" command to fail with an InvalidEncoding exception

[ghost]

Dear @lau-bin,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA¹.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

1. Contributor License Agreement ↩

[ghost]

Dear @lau-bin,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA¹.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

1. Contributor License Agreement ↩

[sesi200]

Hi @lau-bin, thank you very much for your PR. I'll ping the relevant people so they can review this.

[randombit]

This change seems correct to me. The DER encoding 06042b8104000a (what is currently used) is not valid DER at all. In contrast 06052b8104000a is the correct DER encoding for the OID 1.3.132.0.10 (secp256k1)

AIUI this "EC PARAMETERS" block is just being printed out for the user during key derivation, and the variable is not used outside of that context. So it seems safe enough to change. Certainly no other software will be able to correctly interpret the value we are printing right now.

[lwshang]

FYI, on the agent-rs side (used by dfx), such EC PARAMETER was also hard-coded:
https://github.com/dfinity/agent-rs/blob/main/ic-agent/src/identity/secp256k1.rs#L37

And thank you @randombit for pointing out that such bytes are DER encoding of OID.
My plan is to merge this quick fix and make a release soon.
Then I may refactor the code for better maintainability.

[lwshang]

Hi @lau-bin, would you mind approve DFINITY's CLA? So that I can merge this work.

[lwshang]

Close by #124