Update rust dependencies #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking into this! At one point I tried updating the dependencies to no effect, but it looks like the bug might've been fixed since then. I will merge this into the PR and do some testing to make sure it works in the browser, VS Code extension, etc. The contribution is highly appreciated! |
rvanasa
added a commit
that referenced
this pull request
Jan 14, 2025
* Add test * Add test which currently fails * Update rust dependencies (#152) * Fix merge * 0.10.3 * Update 'mo-fmt' --------- Co-authored-by: Martin Sigloch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also looked into issue #142 today (problem with formatting some unicode/emojis chars) and found a similar issue related to a specific version of wasm-pack: rustwasm/wasm-pack#1389 (comment)
Updating the dependencies seems to resolve the issue. The tests from PR #151 are passing and the snippet I had issues with also doesn't crash any more.