fix(ICRC_Ledger): FI-1654: Update link to script that downloads latest ICRC ledger #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ledger wasm and did files
|
I made a corresponding PR in the examples repo, since the documentation under |
jessiemongeon1
approved these changes
Jan 24, 2025
mbjorkqvist
deleted the
mathias-FI-1654-update-links-to-icrc-download-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script that downloads the latest ICRC ledger
wasmanddidfiles was recently updated to download them using the official ledger releases, rather than the latest commit on themasterbranch of the ic repository.The link to the script in the documentation points to a specific commit in the
icrepository. This PR proposes to update the link to the commit where the script was updated, so that users end up with an officially released ledger.