Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): improve text wrapping in proposal card titles #6392

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 11, 2025

Motivation

The proposal cards have titles that are usually predefined based on the type of proposal. These titles contain spaces, so when their length exceeds the width of the card, the text automatically breaks into lines. However, sometimes these titles are custom, and their format may lack spaces but include underlines.

Before:

Screenshot 2025-02-11 at 08 29 20

After:

Screenshot 2025-02-11 at 08 29 37

Relates to NNS1-3615

Changes

  • Adds CSS property to the titles to break down text based on natural boundaries using break-word.

Tests

  • Manually tested by modifying the translations file locally with a custom breaking title.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title break word in proposal cards fix(styles): improve text wrapping in proposal card titles Feb 11, 2025
@yhabib yhabib marked this pull request as ready for review February 11, 2025 07:44
@yhabib yhabib requested a review from a team as a code owner February 11, 2025 07:44
@yhabib yhabib added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 4671f2c Feb 11, 2025
32 checks passed
@yhabib yhabib deleted the nns1-3615/fix branch February 11, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants