No active field for non-votable neurons #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrasinskis
changed the title
|
Can you look at the failing tests? |
@dskloetd, thanks for the heads-up! |
dskloetd
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In today's implementation, you can have neurons that are unlocked but have been inactive for so long that the "confirm following" warning appears. This is undesired, so the followee confirmation warning shouldn't be shown if the neuron cannot vote.
This PR ensures that the neuron activity field is not displayed on the neuron details page when there is not enough dissolve delay to vote.
Changes
Tests
Todos
Not necessary