Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No missing rewards banners for non-votable neurons #6374

Merged
merged 13 commits into from
Feb 10, 2025

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Feb 9, 2025

Motivation

In today's implementation, you can have neurons that are unlocked but have been inactive for so long that the "confirm following" warning appears. This is undesired, so the followee confirmation warning shouldn't be shown if the neuron cannot vote.

This PR ensures that neurons without enough dissolve delay to vote are filtered out from the derived store. This logic is automatically applied to the related banners and page indicators (red dot).

Changes

  • Filter out non-votable neurons from the missing rewards store.
  • Make banner on neuron details rely on the store to avoid code duplication (changes).

Tests

  • Add dissolveDelaySeconds to addNeuronWith fake api.
  • Updated.
  • Tested locally to ensure that banners and indicators are not shown for non-votable && inactive neurons.

Todos

  • Add entry to changelog (if necessary).

@mstrasinskis mstrasinskis changed the title Vp0 no missing rewards banners No missing rewards banners for non-votable neurons Feb 9, 2025
@mstrasinskis mstrasinskis marked this pull request as ready for review February 9, 2025 17:33
@mstrasinskis mstrasinskis requested a review from a team as a code owner February 9, 2025 17:33
@mstrasinskis mstrasinskis added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 87369ca Feb 10, 2025
32 checks passed
@mstrasinskis mstrasinskis deleted the vp0-no-missing-rewards-banners branch February 10, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants