Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(flags): remove ENABLE_EXPORT_NEURONS_REPORT feature flag #6372

Merged
merged 2 commits into from
Feb 10, 2025
Merged

refactor(flags): remove ENABLE_EXPORT_NEURONS_REPORT feature flag #6372

merged 2 commits into from
Feb 10, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 9, 2025

Motivation

The feature has been enabled by default in production for over a month. We can clean up the code related to the feature flag since there is no need to hide it in the future.

Changes

  • Removed all references to ENABLE_EXPORT_NEURONS_REPORT
  • Removed tests that check the behavior of turning off the feature.

Tests

  • Tests should pass as before.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review February 9, 2025 10:56
@yhabib yhabib requested a review from a team as a code owner February 9, 2025 10:56
@yhabib yhabib added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit d2c683f Feb 10, 2025
32 checks passed
@yhabib yhabib deleted the nns1-3532/remove-ff branch February 10, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @dskloetd