Skip to content

Commit

Permalink
Update changelog after release (#4896)
Browse files Browse the repository at this point in the history
# Motivation

A release has been deployed to production.

# Changes

- Changelog - split out the changes included in the release.
- Increment the patch version of the nns-dapp.
- Update `cargo audit` section in `release-sop`.
  • Loading branch information
mstrasinskis authored May 21, 2024
1 parent 13028eb commit 51a4087
Show file tree
Hide file tree
Showing 16 changed files with 70 additions and 48 deletions.
17 changes: 0 additions & 17 deletions CHANGELOG-Nns-Dapp-unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,31 +15,18 @@ proposal is successful, the changes it released will be moved from this file to

#### Added

* Close modal on ESC key press.
* Add `ENABLE_ACTIONABLE_TAB` feature flag.
* Support `ApiBoundaryNodes` in `FirewallRulesScope` of `AddFirewallRulesPayload`.
* Support `SubnetRental` topic.
* Support NNS function 52 for `SubnetRentalRequest`.
* Get `ckUSDC` canister IDs from environment/configuration.

#### Changed

* Update IC, Candid, and `ic-cdk` dependencies.
* Changed support for NNS function 43 from `AddApiBoundaryNodePayload` (singular) to `AddApiBoundaryNodesPayload` (plural).
* Set `Actionable Proposals` as the default selection.

#### Deprecated

#### Removed

* Stop encoding the accounts map in the `AccountsStore`.
* Removed `ENABLE_HIDE_ZERO_BALANCE` feature flag.
* Proposal filtering by reward status.
* Intermediate step to remove transactions from accounts stored in nns-dapp.

#### Fixed

* Successful swap message should not be shown when participant count is insufficient.
* Rendering tokens with fewer than 8 decimals.
* Don't allow inputting more decimals than the token supports.

Expand All @@ -53,15 +40,11 @@ proposal is successful, the changes it released will be moved from this file to

#### Added

* Added workflow to update IC cargo dependencies.
* Include `ckUSDC` when generating `args.did` and `.env`.
* Include `ckUSDC` canister IDs when importing from URL with `scripts/canister_ids`.

#### Changed

* In `migration-test`, also populate some accounts between upgrade and downgrade.
* Update `dfx` version from 0.15.3 to 0.19.0.

#### Deprecated

#### Removed
Expand Down
39 changes: 39 additions & 0 deletions CHANGELOG-Nns-Dapp.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,45 @@ The NNS Dapp is released through proposals in the Network Nervous System. Theref
Unreleased changes are added to `CHANGELOG-Nns-Dapp-unreleased.md` and moved
here after a successful release.

## Proposal 129748

### Application

#### Added

* Close modal on ESC key press.
* Add `ENABLE_ACTIONABLE_TAB` feature flag.
* Support `ApiBoundaryNodes` in `FirewallRulesScope` of `AddFirewallRulesPayload`.
* Support `SubnetRental` topic.
* Support NNS function 52 for `SubnetRentalRequest`.

#### Changed

* Update IC, Candid, and `ic-cdk` dependencies.
* Changed support for NNS function 43 from `AddApiBoundaryNodePayload` (singular) to `AddApiBoundaryNodesPayload` (plural).

#### Removed

* Stop encoding the accounts map in the `AccountsStore`.
* Removed `ENABLE_HIDE_ZERO_BALANCE` feature flag.
* Proposal filtering by reward status.
* Intermediate step to remove transactions from accounts stored in nns-dapp.

#### Fixed

* Successful swap message should not be shown when participant count is insufficient.

### Operations

#### Added

* Added workflow to update IC cargo dependencies.

#### Changed

* In `migration-test`, also populate some accounts between upgrade and downgrade.
* Update `dfx` version from 0.15.3 to 0.19.0.

## Proposal 129618

### Application
Expand Down
6 changes: 3 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ members = [
resolver = "2"

[workspace.package]
version = "2.0.76"
version = "2.0.77"

[workspace.dependencies]
ic-cdk = "0.13.3"
Expand Down
4 changes: 2 additions & 2 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dfinity/nns-dapp",
"version": "2.0.76",
"version": "2.0.77",
"private": true,
"license": "SEE LICENSE IN LICENSE.md",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion scripts/nns-dapp/release-sop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ confirm_cmd git push origin -f tags/release-candidate
record "Security test: npm audit" npm_audit
verify "Security test: npm audit" "Expected npm audit" echo "found 0 vulnerabilities"
record "Security test: cargo audit" cargo_audit
verify "Security test: cargo audit" "Expected cargo audit" echo "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336"
verify "Security test: cargo audit" "Expected cargo audit" echo "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336"
record "Security test: no HTML in templates" no_html_in_templates
confirm_cmd "$SOURCE_DIR/download-ci-wasm" --commit tags/release-candidate --dir "$TOP_DIR/release/ci" --wasm-filename nns-dapp.wasm.gz
record "CI NNS-dapp WASM hash" "$SOURCE_DIR/get-hash-from-ci-log" --commit tags/release-candidate
Expand Down
4 changes: 2 additions & 2 deletions scripts/nns-dapp/release-sop-test-continue-after-success.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@
"git push origin -f tags/release-candidate: Was already done. Skipping.",
"Security test: npm audit: Was already: \u001b[35mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: found 0 vulnerabilities",
"Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"Security test: no HTML in templates: Was already: \u001b[35mChecked\u001b[0m",
"scripts/nns-dapp/download-ci-wasm --commit tags/release-candidate --dir /home/runner/work/nns-dapp/release/ci --wasm-filename nns-dapp.wasm.gz: Was already done. Skipping.",
"CI NNS-dapp WASM hash: Was already: \u001b[35m6fbaddd1b8fde76de97ca1b03a356f01741878d6210cd9b7c6753ae80ae374a4\u001b[0m",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
"git push origin -f tags/release-candidate: Was already done. Skipping.",
"Security test: npm audit: Was already: \u001b[35mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: found 0 vulnerabilities",
"Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"Security test: cargo audit: Was already: \u001b[35mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"Security test: no HTML in templates: Was already: \u001b[35mChecked\u001b[0m",
"scripts/nns-dapp/download-ci-wasm --commit tags/release-candidate --dir /home/runner/work/nns-dapp/release/ci --wasm-filename nns-dapp.wasm.gz: Was already done. Skipping.",
"CI NNS-dapp WASM hash: Was already: \u001b[35m6fbaddd1b8fde76de97ca1b03a356f01741878d6210cd9b7c6753ae80ae374a4\u001b[0m",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
},
{
"command": "cargo_audit",
"stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stderr": "",
"exitCode": 0
},
Expand Down Expand Up @@ -194,8 +194,8 @@
"git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m",
"Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: no HTML in templates: \u001b[32mChecked\u001b[0m",
"👇 Press enter to run the following command:",
"",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
},
{
"command": "cargo_audit",
"stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stderr": "",
"exitCode": 0
},
Expand Down Expand Up @@ -164,8 +164,8 @@
"git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m",
"Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: no HTML in templates: \u001b[32mChecked\u001b[0m",
"👇 Press enter to run the following command:",
"",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"Security test: cargo audit: \u001b[32mRUSTSEC-1999-0001\u001b[0m",
"Values don't match!",
"Security test: cargo audit: RUSTSEC-1999-0001",
"Expected cargo audit: RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336"
"Expected cargo audit: RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336"
],
"expectedExitCode": 1
}
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
},
{
"command": "cargo_audit",
"stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stderr": "",
"exitCode": 0
},
Expand Down Expand Up @@ -146,8 +146,8 @@
"git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m",
"Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: no HTML in templates: \u001b[32mChecked\u001b[0m",
"👇 Press enter to run the following command:",
"",
Expand Down
6 changes: 3 additions & 3 deletions scripts/nns-dapp/release-sop-test-different-wasm-hash.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
},
{
"command": "cargo_audit",
"stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stderr": "",
"exitCode": 0
},
Expand Down Expand Up @@ -118,8 +118,8 @@
"git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m",
"Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: no HTML in templates: \u001b[32mChecked\u001b[0m",
"👇 Press enter to run the following command:",
"",
Expand Down
6 changes: 3 additions & 3 deletions scripts/nns-dapp/release-sop-test-html-in-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
},
{
"command": "cargo_audit",
"stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stderr": "",
"exitCode": 0
},
Expand Down Expand Up @@ -106,8 +106,8 @@
"git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m",
"Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: no HTML in templates: Failed"
],
"expectedExitCode": 1
Expand Down
6 changes: 3 additions & 3 deletions scripts/nns-dapp/release-sop-test-successful-release.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
},
{
"command": "cargo_audit",
"stdout": "RUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stdout": "RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336",
"stderr": "",
"exitCode": 0
},
Expand Down Expand Up @@ -194,8 +194,8 @@
"git push origin -f tags/release-candidate: \u001b[32mDone\u001b[0m",
"Security test: npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Expected npm audit: \u001b[32mfound 0 vulnerabilities\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2020-0071,RUSTSEC-2020-0159,RUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Expected cargo audit: \u001b[32mRUSTSEC-2024-0019,RUSTSEC-2024-0332,RUSTSEC-2024-0336\u001b[0m",
"Security test: no HTML in templates: \u001b[32mChecked\u001b[0m",
"👇 Press enter to run the following command:",
"",
Expand Down

0 comments on commit 51a4087

Please sign in to comment.