EOP: Using a Dedicated Stable Option Type in Persistent State #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-blaeser
commented
Jul 5, 2024
crusso
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Seems like a sensible precaution (https://github.com/rust-lang/rfcs/blob/master/text/2195-really-tagged-unions.md).
|
Thank you for the review, Claudio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOP: Using a Dedicated Stable Option Type in Persistent State
Related to enhanced orthogonal persistence, see #4193.
As the Rust-native
Optiontype may change its implementation and memory representation in future Rust releases, the runtime system for enhanced orthogonal persistent should use a dedicated option type in the internal persistent state. This dedicated option type has a long-term fixed representation (in C-layout convention) and is used in the garbage collector state that is again part of the persistent metadata.