Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: actor self reference oddity #4731

Closed
crusso opened this issue Oct 10, 2024 · 2 comments · Fixed by #4719
Closed

bug: actor self reference oddity #4731

crusso opened this issue Oct 10, 2024 · 2 comments · Fixed by #4719
Labels
Bug Something isn't working

Comments

@crusso
Copy link
Contributor

crusso commented Oct 10, 2024

See:

https://forum.dfinity.org/t/what-is-special-about-actor-wrapper-and-this-motoko/36049
@crusso
Copy link
Contributor Author

crusso commented Oct 10, 2024

Line 94 in definedness.ml skips the expression in ActorUrlE.. so we ignore any this reference from within an the actorUrlE expression.
Maybe it was generalized from a string lit to an expression at some point but not fixed here

@crusso
Copy link
Contributor Author

crusso commented Oct 10, 2024

Morally, that's a (convenient) bug.

@ggreif ggreif added the Bug Something isn't working label Oct 10, 2024
@ggreif ggreif changed the title BUG: actor self reference oddity bug: actor self reference oddity Oct 10, 2024
@ggreif ggreif changed the title bug: actor self reference oddity bug: actor self reference oddity Oct 10, 2024
@ggreif ggreif mentioned this issue Oct 10, 2024
Merged
11 tasks
ggreif added a commit that referenced this issue Oct 14, 2024
@ggreif
fix #4731
6abf618 
this was a obvious omission
@mergify mergify bot closed this as completed in #4719 Oct 17, 2024
@mergify mergify bot closed this as completed in 0a0eb38 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow access to Self and its public methods from actor initialisers dfinity/motoko
2 participants
@crusso @ggreif