feat: rename and test verify_message_signature()
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Dec 5, 2023
THLO
reviewed
Dec 5, 2023
Comment on lines
+4
to
+5
| if !hex.starts_with("0x") { | ||
| return None; |
There was a problem hiding this comment.
Why is this preferable to simply cutting off 0x if it occurs at the beginning?
There was a problem hiding this comment.
I've tried both, and this approach is more consistent with the wider Ethereum ecosystem (since JSON-RPC providers generally require the 0x prefix).
Allowing hex strings without the prefix led to confusion in the ic-eth-starter project, so I'd rather start this way and then relax the constraints (rather than the other way around).
THLO
approved these changes
Dec 5, 2023
Co-authored-by: Thomas Locher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify_signature()toverify_message_signature()blobvalues (for consistency with the rest of the canister)See this Google Docs comment thread for context.