feat: use registered API keys in Candid-RPC methods #90
Conversation
rvanasa
changed the title
| json, | ||
| max_response_bytes, | ||
| async fn http_request( | ||
| _provider: &RpcNodeProvider, |
There was a problem hiding this comment.
The provider param will eventually be used for logging. For context, the http_request() method was originally added to enable mock HTTP outcalls in unit tests, but I removed this in favor of using state machine tests.
| let providers = providers.borrow(); | ||
| Some( | ||
| providers | ||
| .iter() |
There was a problem hiding this comment.
Wouldn't it be more efficient to use a hash map rather than iterating through the whole list (possibly twice)?
There was a problem hiding this comment.
Currently feels like a premature optimization (expecting maybe 10 providers overall), but it would make sense to eventually use a HashMap. I will definitely keep this in mind.
| ETH_MAINNET_CHAIN_ID, | ||
| match provider { | ||
| EthereumProvider::Ankr => "rpc.ankr.com", | ||
| EthereumProvider::BlockPi => "ethereum.blockpi.network", |
There was a problem hiding this comment.
FYI @rvanasa : We are going to kick out BlockPi on the used providers for ckETH because it (without API keys) it has a hard limit of 25kB on the response size of any request that was problematic for us (eth_getLogs)
This PR changes the Candid-RPC methods to use registered
RpcProviderAPI keys (previously only used for generic JSON-RPC requests).Resolves #73.