feat!: support custom Candid-RPC sources #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-eth-rpc into remove-service-variant
rvanasa
changed the title
THLO
reviewed
Feb 5, 2024
THLO
approved these changes
Feb 5, 2024
gitlab-dfinity
pushed a commit
to dfinity/ic
that referenced
this pull request
Feb 7, 2024
refactor(evmrpc): misc. * Uses `Vec<Vec<FixedSizeData>>` to represent topics in place of `Vec<FixedSizeData>`. * Refactors to support custom RPC services (such as L2s) in the Candid-RPC methods. Prerequisite for [#158](dfinity/evm-rpc-canister#158) and [#165](dfinity/evm-rpc-canister#165). Merges into the `evm-rpc-canister` branch. See merge request dfinity-lab/public/ic!17485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines
JsonRpcSourcewithRpcServiceand extendsRpcSource(now renamed toRpcServicesfor clarity) in a way that makes it possible to use custom EVM networks and JSON-RPC URLs in the Candid-RPC methods (which until now only supported the Ethereum mainnet and Sepolia testnet). This directly addresses most of the community feedback that we've received up to this point. I also used this as an opportunity to clean up some of the glue code needed to combine the original Ethereum integration and ckETH canisters.Includes changes from #165 due to both depending on !17485.
Resolves #166.
Since this will require a lot of new test cases for various EVM chains, I will tackle that in a separate PR.