logs: remove TraceHttp entries from HTTP endpoint
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
approved these changes
Jan 26, 2024
gitlab-dfinity
pushed a commit
to dfinity/ic
that referenced
this pull request
Jan 29, 2024
…ister' feat(evmrpc): set up `evm-rpc-canister` branch Prerequisite changes for [#146](dfinity/evm-rpc-canister#146), [#147](dfinity/evm-rpc-canister#147), and [#148](dfinity/evm-rpc-canister#148) in the [EVM RPC canister](https://github.com/internet-computer-protocol/ic-eth-rpc) repository. Merges into the `evm-rpc-canister` branch. * Adds an `RpcConfig` struct with optional `response_size_estimate` field. * Changes the default response size estimate for `eth_getLogs` from 100 to 1024. * Refactors the ckETH max header size so that it is not added to the custom response size. * Updates CI based on the requirements for the `evm-rpc-canister` branch. * Removes the `Debug` trait from `RpcApi` (which may contain API keys). * Adjusts `ValidationError` enum variants. Note that these changes will not be merged into `master` at any point and are only used for the EVM RPC canister. See merge request dfinity-lab/public/ic!17319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all
TraceHttplog entries from the public/logsAPI endpoint, since these messages could include API keys of custom RPC service URIs or other potentially sensitive information.I also removed the
Debugtrait from anything storing an API key to ensure that we cannot accidentally include these in log messages.