feat: add Alchemy to RPC service list #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
commented
Jan 8, 2024
| @@ -147,7 +147,7 @@ shared ({ caller = installer }) actor class Main() { | |||
| await canister.eth_getTransactionCount( | |||
| ethMainnetSource, | |||
| { | |||
| address = "0xdAC17F958D2ee523a2206206994597C13D831ec7"; | |||
| address = "0x1789F79e95324A47c5Fd6693071188e82E9a3558"; | |||
There was a problem hiding this comment.
CI was occasionally running into request size limits for BlockPI, so this adjusts the test to use a less active smart contract address (ckStagingETH instead of ckETH).
rvanasa
commented
Jan 8, 2024
|
|
||
| // Limited API credentials for local testing. | ||
| // Use `dfx canister call evm_rpc updateProvider ...` to pass your own keys. | ||
| pub const ALCHEMY_ETH_MAINNET_CREDENTIAL: &str = "/v2/zBxaSBUMfuH8XnA-uLIWeXfCx1T8ItkM"; |
There was a problem hiding this comment.
Note that these API keys are intended as defaults for local dev environments (separate from the production keys).
THLO
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Alchemy in the list of built-in RPC services.