feat: add canister metrics #107
Conversation
…ic-eth-rpc into candid-rpc-metrics
e2e/motoko/Main.mo
Outdated
| @@ -109,7 +109,7 @@ shared ({ caller = installer }) actor class Main() { | |||
| }; | |||
|
|
|||
| let candidRpcCycles = 1_000_000_000_000; | |||
| let ethMainnetSource = #EthMainnet(?[#Ankr, #BlockPi, #Cloudflare, #PublicNode]); | |||
| let ethMainnetSource = #EthMainnet(?[#Ankr, #Cloudflare, #PublicNode]); | |||
There was a problem hiding this comment.
Was causing intermittent CI issues due to the response size limits. I'll see if there's a way to add it back in.
| source: &ResolvedJsonRpcSource, | ||
| json_rpc_payload: &str, | ||
| payload_size_bytes: usize, |
There was a problem hiding this comment.
Why is payload_size_bytes of type usize but max_response_bytes is u64?
There was a problem hiding this comment.
Switching payload_size_bytes to u64 causes a lot of unnecessary conversions (since string/vec lengths are always returned as usize), whereas max_response_bytes is always a u64 due to being passed by the developer. It's a bit of an awkward situation, and it bugs me as well.
I'll explore changing this in a separate PR for a cleaner diff.
src/accounting.rs
Outdated
| 1000, | ||
| ); | ||
| let estimated_cost_10_extra_bytes = base_cost | ||
| + 10 * (INGRESS_MESSAGE_BYTE_RECEIVED_COST + HTTP_OUTCALL_BYTE_RECEIEVED_COST) |
There was a problem hiding this comment.
HTTP_OUTCALL_BYTE_RECEIEVED_COST -> HTTP_OUTCALL_BYTE_RECEIVED_COST
There was a problem hiding this comment.
Thanks for catching that. For the record, this typo was in the original canister before I started working on it (along with many others).
src/accounting.rs
Outdated
| + 10 * (INGRESS_MESSAGE_BYTE_RECEIVED_COST + HTTP_OUTCALL_BYTE_RECEIEVED_COST) | ||
| * nodes_in_subnet as u128 | ||
| / NODES_IN_DEFAULT_SUBNET as u128; | ||
| // Request body with 10 additional bytes should be within 1 cycle of expected cost |
There was a problem hiding this comment.
Can you clarify where the 1-cycle difference comes from?
There was a problem hiding this comment.
Updated the comment; it's due to rounding since the unit test approximates the difference in cycles.
| RpcSource::EthMainnet(None), | ||
| RpcSource::EthMainnet(Some(vec
Includes metrics available on the
/metricsHTTP endpoint in the standardic-metrics-encoderformat.Progress:
getMetricscanister method for simplified programmatic accessNote that the metrics are currently not stored in stable memory, so redeploying the canister will reset the metrics. This is intentional to allow breaking changes over time and will also make it quicker to recognize problems with newly deployed canisters. Total statistics can be computed from downstream monitoring services by integrating over all increases in metric numbers. Suggestions are welcome for different ways to approach persistence between upgrades.
Resolves #86.